Skip to content

Conversation

@intelliapps
Copy link

Updated to replace iframe in index.php with content loaded from articles.php (was db.php) via an ajax request.

NB I noticed that the value of the 'site' select input doesn't seem to be used presently to retrieve data but have passed it's value into articles.php anyway.

@agnelvishal
Copy link
Owner

I wanted ajax request to be sent to rest api instead of article.php or db.php. This will eliminate the need to expose database credentials.

@intelliapps
Copy link
Author

I would be happy to have a go at that if you raise it as another issue. I absolutely agree that articles.php needs work (I usually work with the Symfony framework which has a very well defined structure) but I believe I have done exactly what was requested in the issue I was addressing. This was already a fair amount of work and migrating articles.php into the rest API will be a fair amount also.

@intelliapps
Copy link
Author

If possible, you should exclude the third party jquery library files from the automated code reviews.
Also, for production jquery-3.3.1.min.js should be loaded in place of jquery-3.3.1.js

@agnelvishal
Copy link
Owner

Rest api has been updated with database access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants