-
Notifications
You must be signed in to change notification settings - Fork 22
Iframes to ajax #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Iframes to ajax #22
Conversation
…ably it will be used at some point.
…lete empty merge conflict).
# Conflicts: # articles.php # css/style.css # js/autoSubmit.js
|
I wanted ajax request to be sent to rest api instead of article.php or db.php. This will eliminate the need to expose database credentials. |
|
I would be happy to have a go at that if you raise it as another issue. I absolutely agree that articles.php needs work (I usually work with the Symfony framework which has a very well defined structure) but I believe I have done exactly what was requested in the issue I was addressing. This was already a fair amount of work and migrating articles.php into the rest API will be a fair amount also. |
|
If possible, you should exclude the third party jquery library files from the automated code reviews. |
|
Rest api has been updated with database access |
Updated to replace iframe in index.php with content loaded from articles.php (was db.php) via an ajax request.
NB I noticed that the value of the 'site' select input doesn't seem to be used presently to retrieve data but have passed it's value into articles.php anyway.