refactor: consolidate to single memory-efficient scanner implementation #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove redundant stream command and consolidate with encode - Simplify Scanner API to single NewScanner(r, opts...) method - Use memory-efficient scanner implementation for all encoding (O(1) memory) - Add byte counting for stdin inputs when metrics are enabled - Update documentation to reflect removal of stream command The scanner-based implementation is strictly superior to the old encode implementation - it handles everything encode did with constant memory usage instead of linear, making it suitable for files of any size. BREAKING CHANGE: Removed stream command (use encode instead) BREAKING CHANGE: Removed NewScannerOptions method (use NewScanner with options) 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. ℹ️ You can also turn on project coverage checks and project coverage reporting on Pull Request comment Thanks for integrating Codecov - We've got you covered ☂️ |
jackspirou
added a commit
that referenced
this pull request
Aug 6, 2025
- Remove references to stream.go file in CLAUDE.md - Update cmd/tokenizer/README.md to remove stream command examples - Fix NewScannerOptions references in IMPLEMENTATION.md - Regenerate shell completions without stream command These changes reflect the consolidation to a single memory-efficient scanner implementation that was merged in PR #4. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR consolidates the tokenizer to use a single memory-efficient implementation, eliminating code duplication and improving memory usage for all inputs.
Changes
streamcommand - Theencodecommand now handles all cases efficientlyNewScanner()andNewScannerOptions()to a singleNewScanner(r io.Reader, opts ...ScannerOption)following Go conventionsBreaking Changes
streamcommand (useencodeinstead - it now handles streaming efficiently)NewScannerOptionsmethod (useNewScannerwith options)Why This Change?
The previous implementation had two separate code paths:
encode: Read entire input into memory (O(n) memory complexity)stream: Used scanner with bounded memory (O(1) memory complexity)The scanner implementation is strictly superior - it handles everything the old encode did but with constant memory usage. There was no reason to maintain both implementations.
Testing
Performance
The new implementation:
🤖 Generated with Claude Code