-
Notifications
You must be signed in to change notification settings - Fork 3
Universal container platform with tailscale and SSH #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
cccc8de to
f16f668
Compare
40913ce to
6a9c614
Compare
| } | ||
|
|
||
| #[async_trait] | ||
| pub trait ContainerPlatform<T: ContainerModelVersion> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we also probably want a has_resources or something that can check if the platform has the accelerators requested.
In some situations the user may just give an accelerator like 1:A100 without providing a platform, or with providing multiple platforms. In those cases we want to find out which platform has the accelerator they requested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm still figuring out how I want to distribute that logic (e.g., do I ask the platform implementation whether it can schedule a workload, or do we have abstract capabilities in a Platform data model that we can check against), but I'm planning to have capability and capacity checks so that a container can be placed without the user specifying a platform.
771206c to
6b0c9b7
Compare
No description provided.