fix(core): sanitize interrupted tool call arguments#1157
Open
Alexxigang wants to merge 3 commits intoagentscope-ai:mainfrom
Open
fix(core): sanitize interrupted tool call arguments#1157Alexxigang wants to merge 3 commits intoagentscope-ai:mainfrom
Alexxigang wants to merge 3 commits intoagentscope-ai:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why this fix
When a streaming tool call is interrupted mid-JSON, AgentScope can persist a partial
ToolUseBlock.contentstring into memory. On the next request, the DashScope/OpenAI formatter path reuses that invalid JSON as tool-call arguments, which can trigger provider-side 400 errors.This patch fixes the bug at two layers:
ToolCallsAccumulatornow normalizes incomplete raw argument fragments to either serialized structured input or{}before the message is finalizedDashScopeToolsHelperandOpenAIMessageConverternow defensively sanitize historicalToolUseBlock.contentbefore sending it back to providersFixes #1147.
Validation
mvn -pl :agentscope-core -am spotless:applymvn -pl :agentscope-core -am "-Dtest=ToolCallsAccumulatorTest,DashScopeToolsHelperComprehensiveTest,OpenAIMessageConverterTest,ToolCallJsonUtilsTest" test