fix(telemetry): use max instead of sum for streaming token usage aggregation#1098
Open
LearningGp wants to merge 1 commit intoagentscope-ai:mainfrom
Open
fix(telemetry): use max instead of sum for streaming token usage aggregation#1098LearningGp wants to merge 1 commit intoagentscope-ai:mainfrom
LearningGp wants to merge 1 commit intoagentscope-ai:mainfrom
Conversation
…egation Made-with: Cursor
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts telemetry aggregation for streaming ChatResponse so that token usage is treated as cumulative across chunks (taking the maximum observed value) rather than summing per-chunk values, which can overcount for providers that report cumulative totals.
Changes:
- Update
StreamChatResponseAggregatorto aggregateinputTokens/outputTokensviaMath.max(...)instead of summation. - Add unit tests covering cumulative-usage (max) behavior and “usage only in last chunk” behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| agentscope-extensions/agentscope-extensions-studio/src/main/java/io/agentscope/core/tracing/telemetry/StreamChatResponseAggregator.java | Switch token usage aggregation from sum to max for streaming telemetry. |
| agentscope-extensions/agentscope-extensions-studio/src/test/java/io/agentscope/core/tracing/telemetry/StreamChatResponseAggregatorTest.java | Add tests validating the new token usage aggregation behavior. |
...-studio/src/main/java/io/agentscope/core/tracing/telemetry/StreamChatResponseAggregator.java
Show resolved
Hide resolved
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AgentScope-Java Version
1.0.11
Description
use max instead of sum for streaming token usage aggregation
fix #1104
Checklist
Please check the following items before code is ready to be reviewed.
mvn spotless:applymvn test)