[ refactor ] remove redundant private lemma in Data.Sum.Algebra#2908
Merged
jamesmckinna merged 1 commit intoagda:masterfrom Jan 23, 2026
Merged
[ refactor ] remove redundant private lemma in Data.Sum.Algebra#2908jamesmckinna merged 1 commit intoagda:masterfrom
private lemma in Data.Sum.Algebra#2908jamesmckinna merged 1 commit intoagda:masterfrom
Conversation
Taneb
approved these changes
Jan 23, 2026
plt-amy
pushed a commit
that referenced
this pull request
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@JacquesCarette 's comment on #2817 took me back to
Data.Sum.Algebra.This PR removes the redundant (but at least:
private) definition♯, because this is (it would seem) easily replaceable in favour of the obvious existing definition inData.Empty.Polymorphic.Base... which is already in theimportlist.Issues (?):
CHANGELOG: API unchangedstdlibis concerned (moreover, as the definition isprivate, it can't affect anything outwith this module!?)