[ refactor ] reorganise Relation.Nullary.Negation.Core to make clean separation of properties#2805
Merged
jamesmckinna merged 3 commits intoagda:masterfrom Oct 26, 2025
Merged
Conversation
5 tasks
JacquesCarette
requested changes
Aug 5, 2025
Collaborator
JacquesCarette
left a comment
JacquesCarette
left a comment
There was a problem hiding this comment.
I like the reorganization and additional comments. I would approve that.
I'm only requesting changes because you've touched something that now seems pointless, so you've taken on the burden of needing to justify why it's still there!
JacquesCarette
approved these changes
Sep 22, 2025
Collaborator
JacquesCarette
left a comment
JacquesCarette
left a comment
There was a problem hiding this comment.
Sorry for the delayed review. This is great.
plt-amy
pushed a commit
that referenced
this pull request
Feb 9, 2026
…n separation of properties (#2805) * refactor: reorganise to make clean separation of properties * refactor: remove `note` * refactor: remove import of `flip`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is somehow an 'intermediate' PR following on from #2803 and before the more radical #2802 , aiming to systematise the organisation of the module into definitions and properties which depend on negation being a connective in minimal logic, and those (fewer, but more powerful) which genuinely rely on ex falso in the form of
Data.Empty.⊥-elim.NB. More in the same spirit may be possible downstream, eg.
DoubleNegationrequires only the minimal properties (modulo definitional proof-irrelevance... which now could also be tackled by [ refactor ] makecontradictionand friends entirely definitionally proof-irrelevant #2802 )style-guiderecommendation preferringcontradictionover⊥-elim#2798