[ refactor ] make n≢i : n ≢ toℕ i argument to lower₁ irrelevant#2783
Open
jamesmckinna wants to merge 8 commits intoagda:masterfrom
Open
[ refactor ] make n≢i : n ≢ toℕ i argument to lower₁ irrelevant#2783jamesmckinna wants to merge 8 commits intoagda:masterfrom
n≢i : n ≢ toℕ i argument to lower₁ irrelevant#2783jamesmckinna wants to merge 8 commits intoagda:masterfrom
Conversation
JacquesCarette
requested changes
Jul 25, 2025
Collaborator
JacquesCarette
left a comment
There was a problem hiding this comment.
Modulo my comment on whether we even need those extra 2 lemmas, I'm now happy with this.
Collaborator
Author
|
Revisiting this, I'm happy to badge this as |
JacquesCarette
approved these changes
Sep 3, 2025
Closed
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #2748 made me rethink whether
Data.Fin.Base.lower₁is fit-for-purpose (as an inverse toinject₁), or could instead be deprecated in favour of the newData.Fin.Base.lower...This PR doesn't entirely solve that issue, but does prove the two definitions extensionally equal on their domains, as a consequence, perhaps more importantly, of weakening the type of
lower₁so that its precondition is made irrelevant.Two (possibly more downstream) knock-on consequences:
lemmaavoided in favour of [ refactor ] weaken type oflower₁-¬0≢0 : ∀ {ℓ} {A : Set ℓ} → .(0 ≢ 0) → Aencapsulates a repeated pattern of (¬-recompute) reasoning, which ideally would be madeprivate, but is needed in bothBaseandProperties... so, reluctantly, has been added;Relation.Nullary.Negation.Core.contradiction-irr#2785 on which this PR is nowblocked.lower₁could/should be simplified by delegation to those forlower...?i ≢ jargument toData.Fin.Base.punchOutirrelevant #2790Data.Fin.Base.punchOutand its properties could similarly be weakened by making itsi≢j : i ≢ jargument irrelevant! What else might be susceptible to this kind of refactoring?NB. As observed/observable in
README.Data.Fin.Relation.Unary.Top, we can actually avoid having any uses oflower₁in the library, sodeprecationseems possible/desirable #2786UPDATED: no longer
blockedon #2785 .