Add bundled homomorphisms#2383
Conversation
|
Before I look at this at all I just want to say thanks for tackling it! I've been avoiding it with the hope that we can get a solution for #2287, but that looks a long way off. |
|
@Taneb Indeed! This kind of boilerplate-bashing is quite fatiguing, until you run up against the 'diamond' re-export problem, at which point my powers fail me in different ways, trying to work out what should get re-exported from where... plus discovering that (still!) not everything is present which perhaps ought to be... ;-) UPDATED: moving to |
JacquesCarette
left a comment
There was a problem hiding this comment.
This all seems quite reasonable. I am doing this as a comment because it seems incomplete - but I have no specific improvement that I'd like to see in the code that is here.
|
@JacquesCarette @Taneb I have now added the 'missing' parts of the PR (as in the revised opening preamble above), and so (hopefully) now stopping there... |
|
Currently badged as v2.2, but could merge for v2.1? |
|
Have now updated the UPDATED: pending resolution of this issue, PR is now up-to-date and ready-to-merge. @MatthewDaggitt are you happy that your review comments have been addressed? |
|
I think it's fine that they take the full bundles for now. |
Cherry-picked and enhanced from #1962 . Fixes #1960 .
TODO:
Algebra.Morphism.Construct.{Identity|Composition}materialRingWithoutOnedoesn't appear to export its ownRawsubstructure, so that should be added? ditto.KleeneAlgebraStructures/BundlesNB
Setoidstructure onHoms at all... (brain-fade; sigh)SemiringandRinghomomorphisms should export aSuccessorSetHomomorphismstructure/bundleonly after going back to Literals for any ring? #1363 through the medium of (the initial)
SuccessorSetand its consequences forAlgebra.Structureshaving(Is)SuccessorSetfields...