added Pointed algebraic structure, (raw) bundle and homomorphism#1958
Closed
jamesmckinna wants to merge 2 commits intoagda:masterfrom
Closed
added Pointed algebraic structure, (raw) bundle and homomorphism#1958jamesmckinna wants to merge 2 commits intoagda:masterfrom
Pointed algebraic structure, (raw) bundle and homomorphism#1958jamesmckinna wants to merge 2 commits intoagda:masterfrom
Conversation
Collaborator
Author
|
Hmmm... the library disagrees with @JacquesCarette 's analysis that module Relation.Nullary.Construct.Add.Point where
open import Data.Maybe.Base public
using () renaming (Maybe to Pointed; nothing to ∙; just to [_])Maybe this PR isn't required after all? Or at least, in a way which is suitably/sensibly (backwards) compatible. UPDATED: and with apologies for insufficient testing before issuing the PR :-( |
Collaborator
|
See my comments on #1957 . There's a difference between the theory and the free algebra associated to it. I meant the theory, which belongs in |
JacquesCarette
approved these changes
May 4, 2023
Collaborator
Author
This was referenced Jan 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See issue #1957
TODOs:
RawPointedinstance toData.Maybe.BaseFreePointedfunctor, as in The freeMagmaon aSet, resp.Setoid[bis] #1962Data.Nat.Base?List? what else?Pointedback toSetoid