Change batchGet to batch-get for casing consistency across AEP#407
Open
kjvalencik wants to merge 1 commit intoaep-dev:mainfrom
Open
Change batchGet to batch-get for casing consistency across AEP#407kjvalencik wants to merge 1 commit intoaep-dev:mainfrom
kjvalencik wants to merge 1 commit intoaep-dev:mainfrom
Conversation
Member
|
Hi @kjvalencik! Thanks for the contribution. I think this seems very reasonable, especially considering we haven't gotten all of the batch APIs merged into the spec. If you're not a member of the AEP Slack group, we'd love to have you! We're always looking to hear about how people are using/thinking about AEP in the real world |
rambleraptor
approved these changes
Mar 27, 2026
Author
|
Thanks for letting me know about the Slack group. I joined! We're early in our AEP adoption story, but we're pushing hard! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates AEP-0231 (Batch GET) to use
batch-getinstead ofbatchGet/BatchGetin HTTP URI custom method names. This ensures consistent kebab-case naming for custom methods across the AEP, aligning with the casing conventions used by other AEPs (e.g., AEP 122).🍱 Types of changes
What types of changes does your code introduce to AEP? Put an
xin the boxesthat apply
📋 Your checklist for this pull request
Please review the AEP Style and Guidance for
contributing to this repository.
General
references AEPs
correctly.
(run
make lint)Open Questions
Currently api-linter will fail on
batchGetcustom methods. In my opinion, it's preferable to keep the linter and change the standard to use consistent kebab casing. However, if the current standard is intentional, the linter could be updated to understand the difference in convention for custom methods.