Issue/1780 #1793
Open
Issue/1780 #1793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements runtime configuration support following the same pattern used in SMART-EHR-Launcher. Changes: - Updated Dockerfile to remove build-time VITE_* environment variables - Dockerfile now uses multi-stage build with nginx for production - Added config.docker.json as an example configuration file - Updated docker-compose.yaml to use volume mounts for config.json - Added inAppPopulate option to ConfigFile interface - Updated config.ts with new property and validation - Updated public/config.json with new property - Added comprehensive Kubernetes ConfigMap documentation Benefits: - Single Docker image can be deployed across multiple environments - No rebuilds required when changing configuration - Kubernetes-native ConfigMap support - Configuration changes only require pod restart, not image rebuild
|
|
||
| // (Optional) Feature flag to enable/disable in-app population functionality | ||
| // Defaults to true if not specified | ||
| inAppPopulate?: boolean; |
Collaborator
There was a problem hiding this comment.
I did a search for inAppPopulate in the repo and it doesn't seem to be referred to anywhere - so maybe this variable doesn't need to be added? Correct me if I'm missing anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.