Schedule the next occurrence with respect to restrictions#42
Open
idpaterson wants to merge 1 commit intoady624:devfrom
Open
Schedule the next occurrence with respect to restrictions#42idpaterson wants to merge 1 commit intoady624:devfrom
idpaterson wants to merge 1 commit intoady624:devfrom
Conversation
…the condition to avoid unexpected wakeups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change avoids unexpected wakeups of a piston containing a time condition with restrictions. The condition is evaluated correctly according to the restrictions, but the scheduling is set for every day regardless of the restriction.
In the following example reported here the piston wakes at 23:30:00 every day of the week, despite the condition restriction to Friday, Saturday, or Sunday.
There was some code commented out on which this change was based so it is very possible that a problem was discovered back in April (7900693). The modified code should skip to the next non-restricted day and also handle far-future schedules (i.e. > 100 days away).
Review is definitely needed here to avoid negatively affecting other schedules.