Skip to content

Conversation

@shazron
Copy link
Member

@shazron shazron commented Oct 7, 2025

Description

When doing an aio app deploy and an HTTPS_PROXY environment var is set, the aio-cli does not connect to the proxy properly via a SSL CONNECT method, and it gets rejected by a corporate proxy.

Related Issue

See https://jira.corp.adobe.com/browse/IOEXT-1608

Motivation and Context

Enable the aio-cli to connect to proxy servers correctly via SSL CONNECT.

How Has This Been Tested?

  1. clone @adobe/aio-cli-plugin-app, and this repo, at this PR branch
  2. in the @adobe/aio-cli-plugin-app repo folder, use npx link AIO_LIB_RUNTIME_PR_BRANCH_FOLDER_PATH [1]
  3. in the @adobe/aio-cli-plugin-app repo folder:
    a. npm install
    b. aio plugins link .
  4. run Charles Web Proxy (it should run at http://localhost:8888)
  5. Create an App Builder project
  6. deploy it via the proxy by calling: HTTPS_PROXY=http://localhost:8888 aio app deploy
  7. Observe in the Charles Web Proxy window, all connections should use the method CONNECT
  8. deploy it without the proxy by calling: http://localhost:8888 aio app deploy
  9. No connections should be logged in the Charles Web Proxy window

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@MichaelGoberling MichaelGoberling merged commit 296b203 into master Oct 7, 2025
9 checks passed
@MichaelGoberling MichaelGoberling deleted the story/IOEXT-1608 branch October 7, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants