Skip to content

Conversation

@proactivebit
Copy link
Contributor

@proactivebit proactivebit commented Nov 18, 2024

Description

Add retry mechanism in case of token expired error

Related Issue

702

Motivation and Context

Tail log operation should run with no interraption

How Has This Been Tested?

Unit tests, regression tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (96fed0e) to head (23a7474).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #703   +/-   ##
=======================================
  Coverage   99.67%   99.68%           
=======================================
  Files          64       64           
  Lines        1551     1575   +24     
  Branches      218      224    +6     
=======================================
+ Hits         1546     1570   +24     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@proactivebit proactivebit force-pushed the issue/tail-logs-refresh-token branch from 60789c0 to 94dfc14 Compare November 20, 2024 10:36
@proactivebit proactivebit force-pushed the issue/tail-logs-refresh-token branch from 94dfc14 to b5f16fd Compare November 20, 2024 14:15
sii41383
sii41383 previously approved these changes Nov 20, 2024
Copy link
Contributor

@sii41383 sii41383 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code, unit test and regression tests look good.

@proactivebit proactivebit force-pushed the issue/tail-logs-refresh-token branch from 8f59855 to 23a7474 Compare November 22, 2024 08:58
@proactivebit proactivebit merged commit 02be96a into main Nov 22, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants