Fix version upgrade and downgrade above 0.1.4#11
Draft
mrimbault wants to merge 1 commit intoadjust:masterfrom
Draft
Fix version upgrade and downgrade above 0.1.4#11mrimbault wants to merge 1 commit intoadjust:masterfrom
mrimbault wants to merge 1 commit intoadjust:masterfrom
Conversation
- remove the previously introduced direct upgrade path from 0.1.4 to 0.1.6 - change the upgrade and downgrade path 0.1.4 <-> 0.1.5: - only use CREATE OR REPLACE AGGREGATE - drop support for PG 11- that doesn't support it - keep upgrade and downgrade path 0.1.5 <-> 0.1.6 as a no-op Reasoning: - the parallel safety addition introduced by 0.1.5 is only marginally useful for this extension functions, since the main use case requires using ordered aggregates - safely redefining aggregates that may have dependent objects without DROP requires CREATE OR REPLACE AGGREGATE, introduced in PostgreSQL 12 - supporting an alternative logic for PG 11- versions would require extra logic, while these versions have already been EOL for several years
mrimbault
force-pushed
the
fix_parallel_compat_upgrade_path_pg_10
branch
from
1487ac0 to
0c6142e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.1.6
Reasoning:
useful for this extension functions, since the main use case requires
using ordered aggregates
DROP requires CREATE OR REPLACE AGGREGATE, introduced in PostgreSQL 12
extra logic, while these versions have already been EOL for several
years