docs: allow vars file based on distribution fact #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current example from the guide has the problem, that in the variables lookup only `os_family` is and next `distribution` + `distribution_major_version` is considered. This approach leaves a gap for distributions like Ubuntu or Fedora which don't have their own `os_family` but work vastly different than their root distribution. So if Ubuntu has its general settings, you would have to create a vars file for every Ubuntu major version (`Ubuntu_22.yml`, `Ubuntu_24.yml`, etc.). This solution offers the option to have a vars file based on just the `distribution` fact and solves this gap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current example from the guide has the problem, that in the variables lookup only
os_familyis and nextdistribution+distribution_major_versionis considered.This approach leaves a gap for distributions like Ubuntu or Fedora which don't have their own
os_familybut work vastly different than their root distribution.So if Ubuntu has its own general settings, you would still have to create a vars file for every Ubuntu major version (
Ubuntu_22.yml,Ubuntu_24.yml, etc.).This solution offers the option to have a vars file based on just the
distributionfact (Example:Ubuntu.yml) and solves this gap.