✨ Add TV Series Service missing endpoints and models #260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add worktree directory to .gitignore to prevent accidentally committing worktree contents when working on multiple features in parallel. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Implement Plan 2: TV Series Service Additions - adds 10 missing endpoints to achieve 100% API coverage for TV Series Service. **New Models:** - KeywordCollection - Keywords for TV series categorization - TVSeriesTranslationData - TV series-specific translation data - AlternativeTitleCollection - Collection wrapper for alternative titles **Shared Models (reused from Plan 1):** - AccountStates - User rating, favorite, and watchlist state - AlternativeTitle - Alternative titles by country - Translation<T> - Generic translation model - Change models - Change tracking for sync/caching **New Methods:** - accountStates(forTVSeries:session:) - Get user interaction state - addRating(_:toTVSeries:session:) - Add TV series rating - deleteRating(forTVSeries:session:) - Delete TV series rating - keywords(forTVSeries:) - Get TV series keywords - alternativeTitles(forTVSeries:) - Get alternative titles - translations(forTVSeries:) - Get TV series translations - lists(forTVSeries:page:language:) - Get lists containing series - changes(forTVSeries:startDate:endDate:page:) - Get series change history - latest() - Get latest TV series added to TMDb - changes(startDate:endDate:page:) - Get changed TV series IDs **Error Handling:** - Added invalidRating error to TMDbError enum **Tests:** - Added 7 integration tests - Added JSON fixtures for all endpoints - All 1415 unit tests pass - All 110 integration tests pass **Documentation:** - Updated TVSeriesService.md with new method groups - Added new models to TMDb.md - Documentation builds without warnings **API Coverage:** - Before: 14/24 endpoints (58%) - After: 24/24 endpoints (100%) Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (0.73%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #260 +/- ##
==========================================
- Coverage 99.29% 93.17% -6.13%
==========================================
Files 260 276 +16
Lines 4123 4396 +273
==========================================
+ Hits 4094 4096 +2
- Misses 29 300 +271 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implement Plan 2: TV Series Service Additions - adds 10 missing endpoints to achieve 100% API coverage for TV Series Service.
Changes
New Models:
KeywordCollection- Keywords for TV series categorizationTVSeriesTranslationData- TV series-specific translation dataAlternativeTitleCollection- Collection wrapper for alternative titlesShared Models (reused from Plan 1):
AccountStates- User rating, favorite, and watchlist stateAlternativeTitle- Alternative titles by countryTranslation<T>- Generic translation modelChangemodels - Change tracking for sync/cachingNew Service Methods (10 endpoints):
accountStates(forTVSeries:session:)- Get user interaction stateaddRating(_:toTVSeries:session:)- Add TV series rating (0.5-10.0, increments of 0.5)deleteRating(forTVSeries:session:)- Delete TV series ratingkeywords(forTVSeries:)- Get TV series keywordsalternativeTitles(forTVSeries:)- Get alternative titlestranslations(forTVSeries:)- Get TV series translationslists(forTVSeries:page:language:)- Get lists containing serieschanges(forTVSeries:startDate:endDate:page:)- Get series change historylatest()- Get latest TV series added to TMDbchanges(startDate:endDate:page:)- Get changed TV series IDsRequest Classes:
Error Handling:
invalidRatingerror toTMDbErrorenumTests:
Documentation:
TVSeriesService.mdwith 3 new topic groupsTMDb.mdBenefits
API Coverage Improvement
Testing
🤖 Generated with Claude Code