Fix: reset wr_state on first block reception#385
Open
summershrimp wants to merge 1 commit intoadafruit:masterfrom
Open
Fix: reset wr_state on first block reception#385summershrimp wants to merge 1 commit intoadafruit:masterfrom
summershrimp wants to merge 1 commit intoadafruit:masterfrom
Conversation
wr_state resides in SRAM and may contain stale values. Resetting it on the first block ensures correct state and valid data. Signed-off-by: Hakusai Zhang <xm1994@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wr_state resides in SRAM and may contain stale values. Resetting it on the first block ensures correct state and valid data.
Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
UF2_BOARD_IDin your board.h follow correct format from uf2 specsThis checklist items that are not applicable to your PR can be deleted.
Description of Change
Please describe your proposed Pull Request and it's impact.