Improved Memory Management Proper Resource Cleanup and Freeing Allocated Memory#804
Open
Shivam7-1 wants to merge 2 commits intoada-url:mainfrom
Open
Improved Memory Management Proper Resource Cleanup and Freeing Allocated Memory#804Shivam7-1 wants to merge 2 commits intoada-url:mainfrom
Shivam7-1 wants to merge 2 commits intoada-url:mainfrom
Conversation
Author
|
Hii @anonrig Could you please Review This PR whenever you are free :) |
anonrig
reviewed
Dec 20, 2024
anonrig
requested changes
Dec 20, 2024
Member
anonrig
left a comment
There was a problem hiding this comment.
This would reduce our fuzzer coverage.
Author
|
Hii @anonrig |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves memory management by ensuring all dynamically allocated resources are properly freed. It adds early exits with cleanup for invalid parsing and URL checks, ensures out and out_get_origin are freed in all exit paths, and prevents memory leaks, enhancing the robustness and efficiency of the fuzzer code.