Skip to content

Conversation

@gregmolnar
Copy link
Member

No description provided.

@gregmolnar gregmolnar enabled auto-merge (squash) February 6, 2025 21:43
@gregmolnar gregmolnar disabled auto-merge February 6, 2025 21:43
@gregmolnar gregmolnar enabled auto-merge (squash) February 6, 2025 21:45
@gregmolnar gregmolnar disabled auto-merge February 6, 2025 21:49
@gregmolnar gregmolnar merged commit e522dda into main Feb 6, 2025
18 checks passed
@gregmolnar gregmolnar deleted the fix-specs branch February 6, 2025 21:49
@guigs
Copy link

guigs commented Feb 10, 2025

gemspec still have this requirements as dependencies:

s.add_dependency 'activerecord', '>= 6.1.5'
s.add_dependency 'activesupport', '>= 6.1.5'

Should this also be incremented? What exactly Rails support is being dropped?

@gregmolnar
Copy link
Member Author

I will update that(or you can open a PR for it if you'd like), thanks for spotting it. The latest version doesn't support anything below Rails 7.1

@guigs
Copy link

guigs commented Feb 10, 2025

Thanks, but even if we fix that for next version, bundler will still happily install ransack 4.3.0 along with Rails 7.0. What kind of issues can we expect?

@gregmolnar
Copy link
Member Author

I will cut a new release. If you use 4.3.0 with Rails 7, the app shouldn't even start so the tests/specs would fail.

@guigs
Copy link

guigs commented Feb 10, 2025

Our build and all tests are passing with 4.3.0 and Rails 7.0.

@gregmolnar
Copy link
Member Author

Some of the 7 versions will fail, or at least they fell on CI here and I didn't want to fix the issues since those versions of Rails are not supported anymore anyways.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants