Skip to content

Conversation

@FarmerAKH
Copy link
Contributor

Changes:

  • Post and Put for each service (I only changed the "are you sure it is correct?" form)
  • cli-helper file (I only changed the questionare form)
  • Anything that I can type with flags I haven't changed yet regarding the commands if I did bin/acmcsuf-cli [command] [flag]

Additions

  • huh.go file is inside the ./internal/cli/ directory, so just do (go run huh.go) inside that directory

let me know if there are any issues :D

@FarmerAKH
Copy link
Contributor Author

we can prob resolve conflicts later, this is not much of a priority

@GaballaGit
Copy link
Member

Hi Adam, I saw the demo and I think you are doing amazing so far. I will be able to give my review later, currently I am caught up in TA tasks. However, I do have a request for you based on the demo video you sent. Are you able to make it so the huh app doesn't exit immediately after using a command?

For example, we can get events, maybe scroll up and down then, and then ask the app to return back to the commands or different menu. The main menu can also have a quit option to close the huh app too.

@FarmerAKH
Copy link
Contributor Author

FarmerAKH commented Dec 28, 2025

I think that issue should already be fixed. I'll send another demo this afternoon 🙂

@FarmerAKH
Copy link
Contributor Author

Demo Part 2:
https://github.com/user-attachments/assets/c3b3d297-e4cf-4e81-836e-e64bccbb3ed1

Explanation:
In the huh.go file, I implemented these menus using functions, so I have a function for intro menu, announcement menu, event menu, and officer menu, so for each of these menus, I have it go back to the intro menu.

Copy link
Collaborator

@TheJolman TheJolman Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you revert this change with the imports? It's a pointless diff and there is actually a method to the madness rn, we've been doing

import (
	standard library packages
	<blank line>
	third party packages
	<blank line>
	our packages
)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same thing here, this diff doesn't deserve to exist

Copy link
Collaborator

@TheJolman TheJolman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really cool and great work but I have suggestions:

  • When you're ready to merge, we don't want a file called huh.go that you have to run -- the library should integrate cleanly with our existing project structure
  • This feature may benefit from being broken up into smaller more atomic changes: A really good first feature would be replacing the current input forms in files like internal/cli/events/put.go

@FarmerAKH
Copy link
Contributor Author

Ty for taking a look at it Josh.

So, I have the form set at choosing which service to use and test, like choose announcements, officers, or events. Should the starting form be in its own file while the get, put, delete, and post have its own forms in the CLI files already created?

Also any preferences on where that starting form should be cuz I cant decide where?

@FarmerAKH
Copy link
Contributor Author

Ty for taking a look at it Josh.

So, I have the form set at choosing which service to use and test, like choose announcements, officers, or events. Should the starting form be in its own file while the get, put, delete, and post have its own forms in the CLI files already created?

Also any preferences on where that starting form should be cuz I cant decide where?

wait nvm i figured it out now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants