file and folder extract patterns for SimpleFileExtractor#1594
Open
MontrealSergiy wants to merge 7 commits intoaces:masterfrom
Open
file and folder extract patterns for SimpleFileExtractor#1594MontrealSergiy wants to merge 7 commits intoaces:masterfrom
MontrealSergiy wants to merge 7 commits intoaces:masterfrom
Conversation
Contributor
Author
|
it seems there is a bug, convert to draft |
Contributor
Author
|
the PR is reopen with a few minor improvements |
Contributor
|
You can probably edit:
to add information about the new features |
|
|
||
| pat = pat.dup | ||
| pat = Pathname.new(pat).cleanpath | ||
| rep = repls[patidx]&.dup |
Contributor
There was a problem hiding this comment.
Can be
rep = repls[patidx].dup
without the & as it if for folds[patidx] it will return nil if repls do not have patidx. No ?
|
|
||
| <fieldset> | ||
| <legend>Extraction patterns:</legend> | ||
| <legend>Patterns to match and place files </legend> |
Contributor
There was a problem hiding this comment.
I am not sure about this legend.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
improves SimpleFileExtractor to support folder, tree and pattern-driven extraction
see #1076 ( which might still be implemented within Folder browser latter )
and
#1132
May be ComplexFolderExtractor would a better name now. Or maybe AdvancedFolderMixer?
Of course we can keep SimpleFileExtractor as is and create another advanced folder extractor tool. Which could for a while to be open only to admin