-
Notifications
You must be signed in to change notification settings - Fork 748
Smoke - New Component #11220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Smoke - New Component #11220
Conversation
Co-authored-by: PabstMirror <[email protected]>
Co-authored-by: PabstMirror <[email protected]>
|
IMO a bit confusing to have a "smoke" addon that does not change the particles, though I can't think of a better name right now. |
Should it go in the goggles addon where eyewear is already providing protection from other things? |
rautamiekka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Missing macros.
- Inconsistent
*_protectionspellings.
When merged this pull request will:
blockAIVisibilityhemtt launchfor ADTConsiderations:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.