Common - Remove Request Framework

[johnb432]

When merged this pull request will:

• Request Framework has been broken for as long as it's been added (unless Arma behaviour has changed since and it only broke afterwards):
  

  ACE3/addons/common/functions/fnc_receiveRequest.sqf

  Line 50 in e7a034f

  GVAR(RECIEVE_REQUEST_ADD_ACTION_ACCEPT) = _target addAction ["Accept", compile format["[player,'%1', true] call FUNC(onAnswerRequest);", _requestID]];

  throws an error, because FUNC(onAnswerRequest) is not preprocessed into a valid function name.
• Framework is extremely limited, to the point it's not useful in my opinion. If other mods need such a framework, they can easily make their own.
  • It can only handle 1 request at a time.
  • It uses vanilla hints.
  • It uses vanilla actions instead of ACE interactions.
  • You can't customise the action name.
  • You can't pass custom arguments.
• I have been working on modernising the code, but after several attempts I have always come to the conclusion that the framework is not useful and very likely not even used, so not worth updating.

IMPORTANT

• If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
• Development Guidelines are read, understood and applied.
• Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

[LinkIsGrim]

While I agree, we should mark deprecation first.

[johnb432]

While I agree, we should mark deprecation first.

How?

[PabstMirror]

I guess add ACE_DEPRECATED("request framework",3.21,"nothing");
to each sqf (or maybe just the top level one)

but if it has never worked I think we can go straight to removal, as there is nothing to break