-
Notifications
You must be signed in to change notification settings - Fork 21
feat: add reusable Table component with SQLite-backed demo #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
src/routes/demo-table/+page.svelte
Outdated
| let loading = true; | ||
| let error: string | null = null; | ||
|
|
||
| onMount(async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what if we moved this to somewhere in src/lib or created a components/SQLite.svelte that included this logic? But we would want the path passed as a prob
|
Hey, could you please include a screenshot? Also, can you remove the .db file/add it to .gitignore, and instead check in a bash script that creates one, and then not include the table->sqlite db on the default about page? That way we can reproduce the example/use the component but don't have to distribute it with the site, since it's a binary file it'd be better not to have it in git I think. This is cool btw, I'm glad you got this far! |
|
Good point |
|
Updated :D • Refactored SQLite logic into reusable component |
2ab926e to
2d19daa
Compare
|
that looks good! |
|
Can you help resolve the merge conflicts? I may have made a mistake when I tried |
ce698af to
2cea044
Compare
|
Resolved merge conflicts and CI failures by aligning Vitest dependencies and regenerating the lockfile. |

What this adds
<Table />component exported from$lib/demo-table) showing the component in real usagesql.jsand renders query resultsHow to test
/demo-tablestatic/demo.dbNotes
since they pre-exist and seem orthogonal to this change