Skip to content

Conversation

@Samk1710
Copy link

@Samk1710 Samk1710 commented Jan 4, 2026

Addresses Issue:

Data Source: https://cve.tuxcare.com/els/download-json?orderBy=updated-desc

Importer Log Excerpt:

INFO 2026-01-05 10:26:03.844748 UTC Successfully collected 65,599 advisories
INFO 2026-01-05 10:26:03.845009 UTC Step [collect_and_store_advisories] completed in 1373 seconds (22.9 minutes)
INFO 2026-01-05 10:26:03.845091 UTC Pipeline completed in 1373 seconds (22.9 minutes)

Signed-off-by: Sampurna Pyne <[email protected]>
@ziadhany ziadhany self-requested a review January 5, 2026 10:22
Copy link
Collaborator

@ziadhany ziadhany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Samk1710 Thanks , see feedback and suggestions below

Signed-off-by: Sampurna Pyne <[email protected]>
@Samk1710
Copy link
Author

Samk1710 commented Jan 7, 2026

@ziadhany Thanks for your review.
I have updated the code as per your suggestion and feedback. Requesting a re-review. Thanks again!

@Samk1710 Samk1710 requested a review from ziadhany January 7, 2026 21:18
Comment on lines +57 to +60
summary = f"TuxCare advisory for {cve_id}"
if project_name:
summary += f" in {project_name}"
if os_name:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is wrong. The OS name should be considered a qualifier.
Please look at https://github.com/package-url/purl-spec

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a small local script on the data source JSON file to find the unique OS names.

CentOS: 23778
Ubuntu: 13934
Oracle: 8190
AlmaLinux: 6562
Unknown: 4526
CloudLinux: 1934
RHEL: 1524
Debian: 944
TuxCare: 792
Alpine: 119

Idea is to map these with the appropriate PURLs. Will be implementing this and pushing the changes shortly.
Do let me know if any other approach is more suitable. Thanks for the correction.

@ziadhany
Copy link
Collaborator

ziadhany commented Jan 8, 2026

@Samk1710, could you please also fix the CI ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants