test: swap scenario erc20-erc20 #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juangm
force-pushed
the
test/swap-scenario
branch
from
8732fdd to
e02f187
Compare
cesarenaldi
reviewed
Jan 12, 2026
packages/client/src/actions/swap.ts
Outdated
| * kind: SwapKind.Sell, | ||
| * user: evmAddress('0x742d35cc...'), | ||
| * }, | ||
| * quoteId: swapQuoteId('quote_123'), |
Collaborator
There was a problem hiding this comment.
Suggested change
| * quoteId: swapQuoteId('quote_123'), | |
| * quoteId: quote.quoteId, |
cesarenaldi
reviewed
Jan 12, 2026
packages/client/src/actions/swap.ts
Outdated
| * case 'InsufficientBalanceError': | ||
| * return errAsync( | ||
| * new Error(`Insufficient balance: ${plan.required.value} required.`) | ||
| * ); |
Collaborator
There was a problem hiding this comment.
Include a default, cause the plan type disallow exhaustive checking.
cesarenaldi
reviewed
Jan 12, 2026
Collaborator
There was a problem hiding this comment.
Given a user who want to swap tokens
When swapping ERC-20 for the first time
Then they should be able to swap via permit [todo]
Then they shoyld be able to swap by signing 2 transactions
When swapping and ERC-20 for which they have already approved
Then they shoyld be able to swap by signing 1 transaction
When swapping native for ERC-20
Then they should be able to swap by signing 1 transaction [todo]
cesarenaldi
reviewed
Jan 13, 2026
packages/spec/swap/business.spec.ts
Outdated
| assertOk(setup); | ||
| }); | ||
|
|
||
| it('Then they should be able to swap by signing 1 transaction', async ({ |
Collaborator
There was a problem hiding this comment.
Suggested change
| it('Then they should be able to swap by signing 1 transaction', async ({ | |
| it('Then they should be able to swap by signing just the swap order typed data', async ({ |
cesarenaldi
reviewed
Jan 13, 2026
packages/spec/swap/business.spec.ts
Outdated
| assertOk(setup); | ||
| }); | ||
|
|
||
| it('Then they should be able to swap by signing 2 transactions', async ({ |
Collaborator
There was a problem hiding this comment.
Suggested change
| it('Then they should be able to swap by signing 2 transactions', async ({ | |
| it('Then they should be able to swap by sending the ERC20 approval transaction and by signing the swap order typed data', async ({ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.