Skip to content

Update README examples #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
aatxe merged 2 commits into from
Jan 19, 2025
Merged

Update README examples #269

aatxe merged 2 commits into from
Jan 19, 2025

Conversation

@sneakycrow
Copy link
Contributor

@sneakycrow sneakycrow commented Jan 11, 2025

I was implementing your crate (thank you for this btw) and noticed that the edition & crates it was using in the example was a bit outdated

Changes:

  • Updated the Rust Edition to 2021
  • Replaced failure with anyhow

@sneakycrow
Update README examples
111ed0b 
Update editions to 2021 and change out failure for anyhow
@sneakycrow
Re-add Config::load comment
a2979df
aatxe
aatxe approved these changes Jan 19, 2025
View reviewed changes
Copy link
Owner

@aatxe aatxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@aatxe aatxe merged commit e9f0999 into aatxe:develop Jan 19, 2025
3 checks passed
@sneakycrow sneakycrow deleted the patch-1 branch January 19, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aatxe aatxe aatxe approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sneakycrow @aatxe