allow for higher-precision pHash computation #31
+252
−90
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #30
(Disclaimer: I implemented this using some support from Copilot.)
This goes the straightforward way and replaces
u64in theImageHashstruct by aVec<u8>. I am not sure about the performance implications as I don't know the numbers before this PR, but on my machine the benchmarks now look likeI've opted for the smallest possible change to the code, which made the external interface a bit ugly: I added an optional
hash_sizeparameter to all the exposed functions, which is ignored by all algorithms exceptpHash. I guess a better way would be to define an enum where each variant corresponds to one algorithm and contains the parameters for this algorithm, but it changes the interface in a backwards-incompatible way and requires more work on the Python/Rust border, so I wanted to get your feedback first. Please let me know what you think @aastopher.