fix: support authentication field in push notification config

[Soolan]

Description

This PR fixes issue #239 by implementing support for the authentication field in the push notification configuration, which was previously ignored. It adds support for Bearer and Basic authentication schemes in the [Authorization]

Tests added to:
test/server/push_notification_integration.spec.ts

All 10 tests pass by running:
npm test test/server/push_notification_integration.spec.ts

Output:

✓ test/server/push_notification_integration.spec.ts (10 tests)
   ✓ Push Notification Integration Tests (10)
     ✓ End-to-End Push Notification Flow (3)
     ✓ Push Notification Header Configuration Tests (7)
       ✓ should send correct Authorization header when authentication config is provided
       ✓ should send Bearer Authorization header
       ✓ should send Basic Authorization header

Fixes #239 🦕

[gemini-code-assist]

Summary of Changes

Hello @Soolan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves issue #239 by implementing crucial support for the authentication field in push notification configurations. By integrating Bearer and Basic authentication schemes, it significantly enhances the security and compatibility of push notifications, allowing them to properly authenticate with external services. This change ensures that push notifications can leverage standard authorization methods, making the system more robust and aligned with modern security practices.

Highlights

• Authentication Field Support: The pull request introduces support for the authentication field within the push notification configuration, which was previously overlooked.
• Bearer and Basic Authentication Schemes: Specifically, the changes enable the use of Bearer and Basic authentication schemes for push notifications, allowing for more secure and flexible integration.
• New Integration Tests: Comprehensive integration tests have been added to test/server/push_notification_integration.spec.ts to ensure the correct implementation and functionality of the new authentication features.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for Bearer and Basic authentication for push notifications, which is a great enhancement. The implementation correctly handles individual authentication schemes. However, there is a logic flaw when multiple schemes are provided in the configuration, where one will always overwrite the other regardless of the intended preference. I've provided a suggestion to fix this by establishing a clear precedence. Additionally, the corresponding integration test should be strengthened to assert the specific, correct behavior.

[gemini-code-assist]

The current implementation for handling authentication schemes has a flaw. If both Bearer and Basic schemes are present in the schemes array, the Authorization header will always be set to Basic because its check comes after Bearer, overwriting any previously set value. This behavior is non-obvious and likely not what's intended, as the order in the schemes array is ignored.

To make the behavior explicit and prefer one scheme over the other (e.g., Bearer is generally preferred over Basic), you should use an if-else if structure. This ensures only one authentication header is set, with a clear precedence.

        if (schemes.includes('Bearer')) {
          headers['Authorization'] = `Bearer ${credentials}`;
        } else if (schemes.includes('Basic')) {
          headers['Authorization'] = `Basic ${credentials}`;
        }

[gemini-code-assist]

This test case for multiple authentication schemes is not specific enough. It only asserts the existence of an Authorization header, and the comments explain the implementation's flawed behavior (where Basic overwrites Bearer).

Tests should be deterministic and explicitly assert the expected outcome. Once the implementation logic is corrected to handle scheme precedence, this test should be updated to assert the exact value of the Authorization header. The explanatory comments should be removed in favor of a clear assertion.

For example, if Bearer is given precedence, the assertion should be:

assert.equal(notification.headers['authorization'], 'Bearer test-credentials');