Skip to content

Conversation

@ishymko
Copy link
Member

@ishymko ishymko commented Dec 5, 2025

Description

Pass ServerCallContext to TaskStore to allow DB-backed stores. Enhance comments for User, stating that userName is a unique identifier.

Re #213

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ishymko, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the TaskStore interface to allow for more flexible and robust implementations, particularly those that might rely on database interactions, by introducing an optional ServerCallContext. Additionally, it improves the clarity and maintainability of the User interface by adding comprehensive JSDoc comments, ensuring that the purpose and unique nature of the userName property are well-documented.

Highlights

  • TaskStore Context: The TaskStore interface methods, save and load, now accept an optional ServerCallContext parameter. This change is intended to facilitate the development of database-backed task stores by providing necessary call context.
  • User Interface Documentation: Enhanced JSDoc comments have been added to the User interface and its properties, explicitly clarifying that userName serves as a unique identifier for the user.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ishymko ishymko requested a review from guglielmo-san December 5, 2025 15:42
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the TaskStore interface to accept a ServerCallContext, which is a good improvement for enabling database-backed stores. The documentation for the User interface has also been enhanced for clarity. My main feedback is a critical issue in src/server/store.ts: the change to the TaskStore interface breaks existing implementations like InMemoryTaskStore and the test mock MockTaskStore, which will cause the build to fail. These implementations need to be updated to match the new interface signatures.

@ishymko ishymko marked this pull request as ready for review December 5, 2025 15:42
@ishymko ishymko marked this pull request as draft December 5, 2025 15:47
@guglielmo-san guglielmo-san self-requested a review December 5, 2025 16:28
@ishymko ishymko marked this pull request as ready for review December 5, 2025 17:44
@ishymko ishymko enabled auto-merge (squash) December 8, 2025 10:22
@ishymko ishymko merged commit 7d9a0c7 into main Dec 8, 2025
6 checks passed
@ishymko ishymko deleted the ishymko/server-call-context branch December 8, 2025 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants