Standardize Weather Provider Dropdown in Settings #149
Conversation
This change replaces the custom clickable Text implementation with the standard Material 3 ExposedDropdownMenuBox component. This improves accessibility by providing a proper label, read-only text field semantics, and visual affordances (dropdown arrow) consistent with the rest of the application's forms. - Replaced `Row` + `Text` + `DropdownMenu` with `ExposedDropdownMenuBox` - Added `OutlinedTextField` with `readOnly=true` and `MenuAnchorType.PrimaryNotEditable` - Added `ExposedDropdownMenuDefaults.TrailingIcon` - Updated `.jules/palette.md` with learnings on standardized selection controls Co-authored-by: Zoekur <[email protected]>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e8b0aecbf
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ExposedDropdownMenu( | ||
| expanded = expanded, | ||
| onDismissRequest = { expanded = false }, |
There was a problem hiding this comment.
ExposedDropdownMenu is referenced here, but the file only imports ExposedDropdownMenuBox and ExposedDropdownMenuDefaults. Without import androidx.compose.material3.ExposedDropdownMenu, Kotlin reports an unresolved reference and the SettingsScreen fails to compile in any build configuration that includes this file. Add the missing import (or fully qualify the call) to keep the build green.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Pull request overview
This PR standardizes the Weather Provider dropdown in the Settings screen by replacing a custom clickable text implementation with Material 3's ExposedDropdownMenuBox component. This improves accessibility through better semantic roles and keyboard behavior, provides standard visual affordances (outlined field, label, trailing icon), and aligns the UI with Material Design 3 guidelines.
Changes:
- Replaced custom clickable
TextwithOutlinedTextFieldinExposedDropdownMenuBoxfor weather provider selection - Added
MenuAnchorType.PrimaryNotEditableto prevent keyboard input while maintaining interactivity - Applied Material 3 design tokens via
ExposedDropdownMenuDefaults - Documented the standardization approach in
.jules/palette.md
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/main/java/com/dagsbalken/app/ui/settings/SettingsScreen.kt | Migrated weather provider dropdown from custom clickable text to standard Material 3 ExposedDropdownMenuBox with proper imports, styling, and accessibility improvements |
| .jules/palette.md | Added documentation about using ExposedDropdownMenuBox for standardized selection controls to improve discoverability and accessibility |
| import androidx.compose.material3.DropdownMenuItem | ||
| import androidx.compose.material3.ExperimentalMaterial3Api | ||
| import androidx.compose.material3.ExposedDropdownMenuBox | ||
| import androidx.compose.material3.ExposedDropdownMenuDefaults |
There was a problem hiding this comment.
Missing import for ExposedDropdownMenu. The code uses ExposedDropdownMenu at line 360 but this component is not imported. Add the following import statement:
import androidx.compose.material3.ExposedDropdownMenu
Without this import, the code will fail to compile.
| import androidx.compose.material3.ExposedDropdownMenuDefaults | |
| import androidx.compose.material3.ExposedDropdownMenuDefaults | |
| import androidx.compose.material3.ExposedDropdownMenu |
Replaced the custom "Weather Provider" dropdown in SettingsScreen with the standard Material 3 ExposedDropdownMenuBox component. This aligns the UI with the project's design system, improves accessibility (semantics, keyboard behavior), and enhances visual consistency. The change uses
OutlinedTextFieldas the anchor withMenuAnchorType.PrimaryNotEditableto prevent keyboard input while ensuring clear interactivity.PR created automatically by Jules for task 2837260108756549719 started by @Zoekur