Skip to content

Conversation

@wesleyegbertsen
Copy link

@wesleyegbertsen wesleyegbertsen commented Jan 4, 2026

General Remarks

I've been playing on a self-hosted Minecraft server with my little brother. So I try to keep as much as possible in our language (Dutch) as possible. I noticed that everything was translatable except the enchantment name. So I made some changes to support enchantment name translation.

Summary

  • Added translation key enchantment.timberz.timber for the TimberZ enchantment, with as default fallback Timber.
    • The default fallback ensures everything keeps working for people not wanting to use the translation key with a resource pack on their server. But they can, if they want.
  • Added a section to the README explaining how to change the enchantment name via the new enchantment.timberz.timber translation key.
  • Added language file nl-NL.yml for the LocalizationService, and added it to the defaultLangs and updated the config.yml and the config.yml section in the README.
    • I already did the translations for my server, might as well contribute them here.
  • Fixed already existing languages pl-PL & ru-RU not added to the defaultLangs in the LocalizationService. This caused the language files not to be created in the plugins plugin folder of the server.
  • Bumped the patch version of the plugin version, since it's not really a new feature. Rather some extra localization support and fixes for missing default languages..

Testing

I've built the plugin on my machine, and tested the changed plugin on my self hosted server. The nl-NL.yml, pl-PL.yml & ru-RU.yml get properly created in the plugins plugin folder.

Also updated the resource pack I already had created for my server for some other translations with the new translation key enchantment.timberz.timber, and verified it worked as intended. Also verified if the default fallback for the translation key worked as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant