Make enchantment name translatable, add nl-NL translation, and fix missing default languages #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General Remarks
I've been playing on a self-hosted Minecraft server with my little brother. So I try to keep as much as possible in our language (Dutch) as possible. I noticed that everything was translatable except the enchantment name. So I made some changes to support enchantment name translation.
Summary
enchantment.timberz.timberfor the TimberZ enchantment, with as default fallbackTimber.READMEexplaining how to change the enchantment name via the newenchantment.timberz.timbertranslation key.nl-NL.ymlfor theLocalizationService, and added it to thedefaultLangsand updated theconfig.ymland theconfig.ymlsection in theREADME.pl-PL&ru-RUnot added to thedefaultLangsin theLocalizationService. This caused the language files not to be created in the plugins plugin folder of the server.patchversion of the plugin version, since it's not really a new feature. Rather some extra localization support and fixes for missing default languages..Testing
I've built the plugin on my machine, and tested the changed plugin on my self hosted server. The
nl-NL.yml,pl-PL.yml&ru-RU.ymlget properly created in the plugins plugin folder.Also updated the resource pack I already had created for my server for some other translations with the new translation key
enchantment.timberz.timber, and verified it worked as intended. Also verified if the default fallback for the translation key worked as intended.