feat: Integrate several real components into CakeController #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integrates real Watchdog, TaskConvergenceValidator, OperatorBuilder, InterventionAnalyzer, RecallDB, and PTYShim (via cake_exec) components into the CakeController state machine. Key changes: - Watchdog integration uses a callback and event queue. - TaskConvergenceValidator is instantiated; runtime validation in states uses placeholder logic due to mismatched validator scope. - OperatorBuilder and InterventionAnalyzer are used for intervention decisions and message generation in _do_INTERVENING. - RecallDB is used for error/command logging and by InterventionAnalyzer. - PTYShim's cake_exec function is used for command execution. - Synchronous component calls are wrapped with asyncio.to_thread. - I updated the unit tests to support these integrations, typically by patching component classes. This commit represents partial completion of my plan to integrate all real components. SnapshotManager and further refinements are pending.
27 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrates real Watchdog, TaskConvergenceValidator, OperatorBuilder, InterventionAnalyzer, RecallDB, and PTYShim (via cake_exec) components into the CakeController state machine.
Key changes:
This commit represents partial completion of my plan to integrate all real components. SnapshotManager and further refinements are pending.