OCP-1512: make the node version determination robust

[khaled-maruf]

• this makes the version checker a bit more robust and use a default node version for any major version over 1, so that we don't have to handle them seperately everytime.
• this also reads the version from the package.json engine property which makes it more dynamic and let the client repo have control from their end for overrides.

[pawelziebaopti]

let's discuss this approach. this change would force us to bump minimal node version to the one we want to target by the engine. I'm not sure if that's a good approach as it would force us to bump min node versions for all our libs and tools. this can be problematic for tools like ocp-cli, which have app-sdk dependency, but we want to support multiple engine versions. this is the reason we kept node18 as min version for node-sdk and app-sdk.

[khaled-maruf]

let's discuss this approach. this change would force us to bump minimal node version to the one we want to target by the engine. I'm not sure if that's a good approach as it would force us to bump min node versions for all our libs and tools. this can be problematic for tools like ocp-cli, which have app-sdk dependency, but we want to support multiple engine versions. this is the reason we kept node18 as min version for node-sdk and app-sdk.

I'm wondering if we should try to remove the app-sdk and node-sdk dependencies completely from the CLI, My hunch is that we're only using some type definitions from those, which we can override using typescript hacks, that'd let us upgrade our components independent of each other.

Should I remove the NODE_ENGINE read from the package.json from here? And hard code version 3 entry for the package itself?

[pawelziebaopti]

let's discuss this approach. this change would force us to bump minimal node version to the one we want to target by the engine. I'm not sure if that's a good approach as it would force us to bump min node versions for all our libs and tools. this can be problematic for tools like ocp-cli, which have app-sdk dependency, but we want to support multiple engine versions. this is the reason we kept node18 as min version for node-sdk and app-sdk.

I'm wondering if we should try to remove the app-sdk and node-sdk dependencies completely from the CLI, My hunch is that we're only using some type definitions from those, which we can override using typescript hacks, that'd let us upgrade our components independent of each other.

Should I remove the NODE_ENGINE read from the package.json from here? And hard code version 3 entry for the package itself?

as discussed, I agree it makes sense to remove dependencies to app-sdk and node-sdk from ocp-cli.