Skip to content

test(geth-engine): fix flacky stop_program test #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YoEight merged 1 commit into from
Jul 17, 2025
Merged

test(geth-engine): fix flacky stop_program test #43

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
0 ...es/flacky/2_stop_program_subscription.log → ...cky/2_fixed_stop_program_subscription.log
View file
Open in desktop
File renamed without changes.
13 changes: 8 additions & 5 deletions geth-client-tests/src/program_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,12 +162,15 @@ async fn stop_program_subscription() -> eyre::Result<()> {
let proc_id = stream.wait_until_confirmed().await?.try_into_process_id()?;
client.stop_program(proc_id).await?;

// FIXME - it's possible that there are some events prior to the unsubscribed event.
assert!(stream
.next()
.await?
.is_some_and(|x| { matches!(x, geth_common::SubscriptionEvent::Unsubscribed(_)) }));
let mut unsubscribed = false;
while let Some(event) = stream.next().await? {
if let geth_common::SubscriptionEvent::Unsubscribed(_) = event {
unsubscribed = true;
break;
}
}

assert!(unsubscribed);
assert!(stream.next().await?.is_none());

embedded.shutdown().await
Expand Down
Loading