Fix/wic: Fix TypeError in bootimg-partition by adding sector_size argument #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wic core now passes sector_size as a keyword argument. This update ensures the meta-xilinx-core local plugin matches the expected API signature and prevents a TypeError during image generation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a build failure during the do_image_wic task. The error is caused by a signature mismatch in the bootimg-partition source plugin.
The Issue
When using recent versions of the Yocto Project (Poky), the Wic engine's partition.py calls the plugin's do_prepare_partition method with an additional sector_size keyword argument. Because the meta-xilinx-core local copy of this plugin does not include this parameter in its method definition, the build fails with:
The Fix
Updated the do_prepare_partition method signature in scripts/lib/wic/plugins/source/bootimg-partition.py to accept the sector_size argument. This ensures compatibility with the upstream Wic engine API.
Testing Performed
Environment: Yocto Project (Poky) with meta-xilinx.
Build Target: petalinux-image-minimal (or your specific machine, e.g., xczu2eg).
Result: do_image_wic completes successfully, and the resulting .wic image is generated without errors.