feat: scroll, scrollTo #165
Conversation
There was a problem hiding this comment.
PR Overview
This PR adds a new scrollTo functionality to the GhostCursor and updates documentation accordingly.
- Added documentation for the scrollTo function in README.md.
- Extended the GhostCursor interface and implemented the scrollTo function in src/spoof.ts.
- Introduced a new ScrollToOptions interface.
Reviewed Changes
| File | Description |
|---|---|
| README.md | Added documentation for the new scrollTo function |
| src/spoof.ts | Added ScrollToOptions interface, updated GhostCursor interface, and implemented scrollTo |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
src/spoof.ts
Outdated
| : { top: destination.y, left: destination.x } | ||
|
|
||
| window.scrollTo({ | ||
| behavior: optionsResolved.behavior ?? (defaultOptions?.scrollIntoView?.scrollSpeed !== undefined && |
There was a problem hiding this comment.
The page.evaluate callback references 'optionsResolved' and 'defaultOptions' which are not passed into its scope; this may lead to undefined behavior. Consider passing the required values as arguments to the evaluate function.
|
The problem with this is that it's easily detectible by hooking into |
|
@Niek done, refactored to use the same scroll method as |
| } | ||
| }, | ||
|
|
||
| async scroll (delta: Partial<Vector>, options?: ScrollOptions) { |
There was a problem hiding this comment.
Basically just moved this code (unchanged) to its own function that is called by both scrollTo and scrollIntoView
|
Amazing! Merged now! |
2 participants
No description provided.