Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Summary
This PR fixes all failing pytest tests by addressing Python 3.12 compatibility issues with the deprecated
PyInquirerlibrary and migrating to the moderninquirerlibrary.Problem
The tests were failing due to compatibility issues between
PyInquirerand Python 3.12+:ImportError: cannot import name 'Mapping' from 'collections'PyInquireris deprecated and no longer maintainedcollections.Mappingwas moved tocollections.abc.Mappingin Python 3.10+Solution
🔄 Library Migration
PyInquirerwithinquirer(actively maintained alternative)inquirerAPI🧪 Test Fixes
inquirer.promptinstead of the oldpromptfunctionBadCredentialsExceptionconstructor calls with proper status codes🛡️ Robustness Improvements
Changes Made
Core Application (repo_deleter.py)
PyInquirer.prompttoinquirer.Checkboxandinquirer.ListDependencies (requirements.txt)
Test Suite Updates
Additional Improvements
Testing
✅ All tests now pass:
The skipped test (
test_github_api_connection) requires aGITHUB_TOKENenvironment variable and is correctly skipped when not available.Test Coverage
Compatibility
Risk Assessment
How to Test
pip install -r requirements.txtpython -m pytest tests/ -vpython -m github_repo_deleter.repo_deleter --helpGITHUB_TOKENenv var for integration testsFixes: All pytest test failures
Type: Bug Fix, Dependency Update
Breaking Changes: None (same public API)