Open
Conversation
Collaborator
|
I personally wouldn't bother -- this is going to be totally immaterial performance-wise, and obviously prone to breaking if the code changes, and so it is at a very high risk of just remaining in the code as is without anybody caring about whether the groupings still make sense. |
mcrnic
approved these changes
Nov 24, 2025
Collaborator
mcrnic
left a comment
There was a problem hiding this comment.
I don't mind but I personally would not bother. LogsDB is single threaded at the moment. The only other thing accessing these stats is stat exporter which kicks off once a minute.
Collaborator
|
BTW, If we were to merge this, I'd definitely comment the alignas. As a compromise, I think merging without the alignas is harmless. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
these fields are all atomic so the accesses are safe, but different threads end up stepping on each other's toes when accessing different fields
this adds padding and groups together the fields accessed at the same time