Camptix_Payment::get_order() should return the first user as the attendee_id#1546
Closed
dd32 wants to merge 2 commits intoproductionfrom
Closed
Camptix_Payment::get_order() should return the first user as the attendee_id#1546dd32 wants to merge 2 commits intoproductionfrom
dd32 wants to merge 2 commits intoproductionfrom
Conversation
…ndee_id At present CampTix_Payment_Method::get_order() returns the LAST attendee added as part of the transaction as the attendee_id. This is usually incorrect, as the first user is often the person purchasing the ticket, and in the case of requiring user logins, will always be the purchaser.
Member
Author
|
This would break some implementations which store metadata against only the attendee_id, #1551 might be a better route. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At present CampTix_Payment_Method::get_order() returns the LAST attendee added as part of the transaction as the attendee_id.
This is usually incorrect, as the first user is often the person purchasing the ticket, and in the case of requiring user logins, will always be the purchaser.
Partially related to #1427