Skip to content

Fix messageID=0 in message embedded objects #6631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BurntimeX merged 1 commit into from
Mar 18, 2026
+16 −0
Merged

Fix messageID=0 in message embedded objects #6631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions wcfsetup/install/files/acp/update_com.woltlab.wcf_6.3_embeddedObjects.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<?php

use wcf\system\WCF;

// Remove orphaned entries associated with `messageID=0`.
$sql = "DELETE FROM wcf1_message_embedded_object WHERE messageID = ?";
$statement = WCF::getDB()->prepare($sql);
$statement->execute([0]);
8 changes: 8 additions & 0 deletions ...p/install/files/lib/system/message/embedded/object/MessageEmbeddedObjectManager.class.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,10 @@ public function registerObjects(HtmlInputProcessor $htmlInputProcessor, $isBulk
$messageObjectTypeID = $context['objectTypeID'];
$messageID = $context['objectID'];

if (!$messageID) {
throw new \BadMethodCallException("No 'messageID' was set.");
}

// delete existing assignments
if ($removeExistingObjects) {
if ($isBulk) {
Expand Down Expand Up @@ -195,6 +199,10 @@ public function commitBulkOperation()
*/
public function registerSimpleObjects($messageObjectType, $messageID, array $embeddedContent)
{
if (!$messageID) {
throw new \BadMethodCallException("No 'messageID' was given.");
}

$messageObjectTypeID = ObjectTypeCache::getInstance()
->getObjectTypeIDByName('com.woltlab.wcf.message', $messageObjectType);

Expand Down
Loading