Skip to content

Improve a11y of the color picker button #6626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BurntimeX merged 2 commits into from
Mar 9, 2026
+13 −6
Merged

Improve a11y of the color picker button #6626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12cebba
Fix hide of the color picker button
BurntimeX Mar 9, 2026
e42071b
Improve a11y of the color picker button
BurntimeX Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions com.woltlab.wcf/templates/shared_colorFormField.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,15 @@
<span{if $field->getValue()} style="background-color: {$field->getValue()}"{/if}></span>
</span>
{else}
<a href="#" class="colorPickerButton jsTooltip" id="{$field->getPrefixedId()}_colorPickerButton" title="{lang}wcf.style.colorPicker.button.changeColor{/lang}" data-store="{$field->getPrefixedId()}">
<button
type="button"
class="colorPickerButton jsTooltip"
id="{$field->getPrefixedId()}_colorPickerButton"
title="{lang}wcf.style.colorPicker.button.changeColor{/lang}"
data-store="{$field->getPrefixedId()}"
>
<span{if $field->getValue()} style="background-color: {$field->getValue()}"{/if}></span>
</a>
</button>
<input type="hidden" {*
*}id="{$field->getPrefixedId()}" {*
*}name="{$field->getPrefixedId()}" {*
Expand Down
2 changes: 1 addition & 1 deletion ts/WoltLabSuite/Core/Ui/Color/Picker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ class UiColorPicker implements DialogCallbackObject {
this.oldColor!.style.backgroundColor = colorString;
this.input.value = colorString;

if (!(this.element instanceof HTMLButtonElement)) {
if (!(this.element instanceof HTMLButtonElement) || this.element.classList.contains("colorPickerButton")) {
const span = this.element.querySelector("span");
if (span) {
span.style.backgroundColor = colorString;
Expand Down
2 changes: 1 addition & 1 deletion wcfsetup/install/files/js/WoltLabSuite/Core/Ui/Color/Picker.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 3 additions & 2 deletions wcfsetup/install/files/style/ui/colorPicker.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,12 @@
}

.colorPickerButton {
height: 32px;
border-radius: var(--wcfBorderRadius);
height: 50px;
width: 50px;

> span {
height: 32px;
height: 50px;
}
}

Expand Down