-
-
Notifications
You must be signed in to change notification settings - Fork 4
enhancement 🪄:: Sbus: Added serial connection monitoring and getters for additional data #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… additional sbus data
Witty-Wizard
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@magraina, Now the changes look good to me. Let me once test the changes. Then I will merge them
|
@magraina, Can you maybe also add these new functions to the documentation? |
Isn't that auto-generated or am I missing something? |
The |
I might have to have a closer look into |
So I figured how
|
You are right I need to add a dev documentation. |
Related Issue
[Cite any related issue(s) this pull request addresses. If none, simply state "None”]
Description
[Please include a brief description of the changes or features added]
Added a time based connection check for sbus with an additional
getSerialConnectionStatus()method.In case no data is received/processed within 200ms the connection is assumed to be lost.
Added getters to get the additional sbus data bits like failsafe, framelos etc.
The getters can be used to evaluate if the channel data is up to date and valid.
Type of PR
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist:
Additional context:
[Include any additional information or context that might be helpful for reviewers.]