Skip to content

Wikilink The Wall Street Journal collection not showing correct data #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suecarmol merged 1 commit into from
Sep 11, 2025
Merged

Wikilink The Wall Street Journal collection not showing correct data #469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions extlinks/links/management/commands/linkevents_collect.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,9 @@ def _process_events(self, url):
# A tuple value sets each respective value independently.
# https://requests.readthedocs.io/en/latest/user/advanced/#timeouts
timeout=(3.05, 7),
headers={
"User-Agent": 'Wikilink'
}
):
if event.event == "message":
try:
Expand Down Expand Up @@ -208,4 +211,5 @@ def _add_linkevent_to_db(self, link, change, event_data):
)
for url_pattern in url_patterns:
url_pattern.link_events.add(link_event)
url_pattern.collections.add(this_link_collection)
url_pattern.save()
3 changes: 3 additions & 0 deletions extlinks/links/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,18 +291,21 @@ def test_management_command_non_proxy(self):
with self.assertRaises(SystemExit):
call_command("linkevents_collect", test=self.event_data1)
self.assertEqual(LinkEvent.objects.count(), 1)
self.assertEqual("JSTOR", URLPattern.objects.first().collections.first().name)

def test_management_command_proxy_urls(self):
self.assertEqual(LinkEvent.objects.count(), 0)
with self.assertRaises(SystemExit):
call_command("linkevents_collect", test=self.event_data2)
self.assertEqual(LinkEvent.objects.count(), 2)
self.assertEqual("JSTOR", URLPattern.objects.first().collections.first().name)

def test_management_command_dates_with_micro_seconds(self):
self.assertEqual(LinkEvent.objects.count(), 0)
with self.assertRaises(SystemExit):
call_command("linkevents_collect", test=self.event_data3)
self.assertEqual(LinkEvent.objects.count(), 2)
self.assertEqual("JSTOR", URLPattern.objects.first().collections.first().name)

class LinkEventsArchiveCommandTest(TransactionTestCase):
def setUp(self):
Expand Down