Conversation
|
Oh right, I believe CI is failing because the current WASI 0.3 target in the Rust compiler doesn't yet know how to parse the recently updated output of |
|
Ah, you need to rebase this branch to pick up the right wit-bindgen / toolchain / wasmtime combination, would you mind doing that please? |
yoshuawuyts
force-pushed
the
wasmtime-test
branch
from
6f14880 to
f996115
Compare
|
I took the liberty of rebasing the branch and adding a commit to update to the latest WASIp3. WDYT @yoshuawuyts ? |
| wit_bindgen::generate!({ | ||
| inline: r" | ||
| package test:test; | ||
|
|
||
| world test { | ||
| include wasi:clocks/imports@0.3.0-rc-2026-02-09; | ||
| include wasi:cli/command@0.3.0-rc-2026-02-09; | ||
| } | ||
| ", | ||
| // Work around https://github.com/bytecodealliance/wasm-tools/issues/2285. | ||
| features:["clocks-timezone"], | ||
| generate_all | ||
| }); |
There was a problem hiding this comment.
(Drive-by) I introduced https://github.com/WebAssembly/wasi-testsuite/blob/main/tests/rust/wasm32-wasip3/src/clocks.rs, to avoid repeating the same pattern on each test, perhaps we could make use of that module here as well?
4 participants
This upstreams the WASI clocks tests from Wasmtime. This makes progress towards #181, porting a single test to make sure I'm doing things right. Once we land this, I'd like to port the remainder of the tests in bulk.
As I mentioned in #181 as well: I expect there to be some overlap between this test and the existing WASI 0.3 clocks test. Ideally what I'd like to do is finish porting all tests over first, and then move to refactor/de-duplicate some of the tests. My hope is that with that we can unblock Jco from moving onto
wasi-testsuitesooner, delete the WASI 0.3 tests from Wasmtime, and focus more of the effort on updating the shared testsuite here. Thanks!