-
Notifications
You must be signed in to change notification settings - Fork 232
WASIP3 Locking/Waiting Primitives #746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TartanLlama
wants to merge
30
commits into
WebAssembly:main
Choose a base branch
from
TartanLlama:sy/wasip3-locks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+402
−101
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
6e03994
Pass --generate-threading-helpers for WASIP3
TartanLlama 776691c
Newline
TartanLlama 1e176a0
Generate bindings
TartanLlama 418a2cf
Locks
TartanLlama 36a0eed
Cleanup
TartanLlama 6e8568b
Formatting
TartanLlama ac45109
Rename STRONG_LOCK
TartanLlama 1f67537
Rename STRONG_LOCK
TartanLlama 94dd503
Change cwd locking
TartanLlama 5d6abcf
Build fixes
TartanLlama cf950b7
Build fixes
TartanLlama 4311c91
Symbol fixes
TartanLlama f68bf5a
Symbol fixes
TartanLlama 73081cf
Symbol fixes
TartanLlama 47e08ba
Disable shared builds
TartanLlama 1210dca
Update symbols for WASIP3
TartanLlama 7c7c296
Merge branch 'main' into sy/wasip3-locks
TartanLlama e7407c7
Bump wasm-component-ld
TartanLlama afbd65e
Merge branch 'sy/wasip3-locks' of github.com:TartanLlama/wasi-libc in…
TartanLlama 29fb984
Undefined signal fix
TartanLlama 28d741f
Bump wasm-component-ld
TartanLlama 93ab9e4
Symbol fixes
TartanLlama bf037e9
Add __wasm_call_ctors to undefined
TartanLlama 4bd8635
Add component-model-threading feature
TartanLlama a19d2cf
Fix locks
TartanLlama 207dc0d
Fix shared linking
TartanLlama a6ffb7e
Retrigger CI
TartanLlama 518371a
Change init lock
TartanLlama 4fb6925
Disable dynamic linking
TartanLlama 29f8f51
Reenable shared lib
TartanLlama File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could this be behind a
#define/guard/etc for now while we're waiting for wasi-sdk/LLVM/etc to all get updated? That way we could go ahead and land all this in wasi-libc (untested) and follow-up with testing later. My gut is that it shouldn't be too hard to support building with/without coop threads within wasi-libc itself, but if that's too difficult to support then it's fine to wait for a build of LLVM with support for coop threds.