threads: change wasm32-wasi-pthread to wasm32-wasi-threads#381
Merged
Conversation
abrown
changed the title
wasm32-wasi-pthread to wasm32-wasi-threadswasm32-wasi-pthread to wasm32-wasi-threads
loganek
approved these changes
Jan 12, 2023
Collaborator
Author
|
No specific guidance like "we reject this name" but you can see from this comment and this discussion that the name could potentially be considered an issue. With this change I'm trying to avoid any such issues. |
After some thought, I think that we should rename the `THREAD_MODEL=posix` build to avoid confusion. Why? Though in this project the use of this target does involve pthreads, it will not be so in other standard libraries or languages (see, e.g., rust-lang/compiler-team#574). I think it would be preferable to emphasize the "threads" Wasm-level proposal and the "wasi-threads" proposal rather than the specific details of which threading API is being exposed.
abrown
force-pushed
the
wasm32-wasi-threads
branch
from
b91939f to
3124868
Compare
Collaborator
Author
|
@sbc100, @sunfishcode: any objections? |
Collaborator
Author
|
cc: @penzn, @alexcrichton, @yamt |
sbc100
approved these changes
Jan 13, 2023
sunfishcode
approved these changes
Jan 13, 2023
yamt
added a commit
to yamt/wasi-sdk
that referenced
this pull request
Jan 13, 2023
yamt
added a commit
to yamt/toywasm
that referenced
this pull request
Jan 20, 2023
sunfishcode
pushed a commit
to WebAssembly/wasi-sdk
that referenced
this pull request
Jan 20, 2023
* Add a variation of wasi-sdk.cmake for pthread-using apps * Install wasi-sdk-pthread.cmake * Build wasi-libc with THREAD_MODEL=posix as well * wasi-sdk-pthread.cmake: target rename to wasm32-wasi-threads after WebAssembly/wasi-libc#381
loganek
added a commit
to loganek/wasm-micro-runtime
that referenced
this pull request
Jan 24, 2023
The target was updated to wasm32-wasi-threads in wasi-libc (and most likely will stay like that for a while) WebAssembly/wasi-libc#381
loganek
added a commit
to loganek/wasm-micro-runtime
that referenced
this pull request
Jan 24, 2023
The target was updated to wasm32-wasi-threads in wasi-libc (and most likely will stay like that for a while) WebAssembly/wasi-libc#381
john-sharratt
pushed a commit
to john-sharratt/wasix-libc
that referenced
this pull request
Mar 6, 2023
…sembly#381) * Change `wasm32-wasi-pthread` to `wasm32-wasi-threads` After some thought, I think that we should rename the `THREAD_MODEL=posix` build to avoid confusion. Why? Though in this project the use of this target does involve pthreads, it will not be so in other standard libraries or languages (see, e.g., rust-lang/compiler-team#574). I think it would be preferable to emphasize the "threads" Wasm-level proposal and the "wasi-threads" proposal rather than the specific details of which threading API is being exposed. * fix: rename the `expected` output directory as well
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After some thought, I think that we should rename the
THREAD_MODEL=posixbuild to avoid confusion. Why? Though in this project the use of this target does involve pthreads, it will not be so in other standard libraries or languages (see, e.g., rust-lang/compiler-team#574). I think it would be preferable to emphasize the "threads" Wasm-level proposal and the "wasi-threads" proposal rather than the specific details of which threading API is being exposed. I also think it would be good to settle on the name now before this gets exposed in wasi-sdk (WebAssembly/wasi-sdk#287).