Divide data segments across all output files when using wasm2c#2626
Open
white-axe wants to merge 5 commits intoWebAssembly:mainfrom
Open
Divide data segments across all output files when using wasm2c#2626white-axe wants to merge 5 commits intoWebAssembly:mainfrom
white-axe wants to merge 5 commits intoWebAssembly:mainfrom
Conversation
Member
|
Cool! Can you add a test to https://github.com/WebAssembly/wabt/tree/main/test/wasm2c/spec-multi-output that exercises this please? I'm not sure we have anything that uses data segments, much less multiple ones. |
Author
|
The memory_init tests already test reading from memory with multiple data segments. Each of the |
Author
|
Do I still have to write the test or anything else for this pull request? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasm2c has a
--num-outputsflag for splitting the output C file into smaller files to reduce compilation time and memory usage by the compiler, but it only splits the functions across the output files. The data segments are all still put in the first output file instead of being split across the output files. That can cause problems on some PowerPC platforms, where the PowerPC TOC places an upper limit on the size of a translation unit. I've modified the code generator to distribute the data segments across all the output files when the--num-outputsflag is set to something greater than one.